Skip to content

Conversation

@kazupon
Copy link
Contributor

@kazupon kazupon commented Sep 26, 2025

@bomb.sh/[email protected] import did not work because the configuration in tsdown.config.ts was not properly aligned with the exports definition in package.json.

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2025

⚠️ No Changeset found

Latest commit: 75a2567

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 26, 2025

Open in StackBlitz

npm i https://pkg.pr.new/bombshell-dev/tab/@bomb.sh/tab@62

commit: 75a2567

".": {
"types": "./dist/t.d.ts",
"import": "./dist/t.js",
"require": "./dist/t.cjs"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json has "type": "module".
I believe this package is esm only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t know why this pacakge needs examples building, but I’ve kept to it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this was for testing purposes. I will fix that.
Thanks!

@AmirSa12
Copy link
Member

Thank you so much @kazupon !
Let me know if there are any other things that need to be addressed.

@AmirSa12 AmirSa12 merged commit 97f9bce into bombshell-dev:main Sep 26, 2025
7 of 8 checks passed
@kazupon kazupon deleted the fix/type-exporting branch September 26, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants